steamcompmgr: Update _NET_WM_STATE when state changes#2069
Open
cgutman wants to merge 1 commit intoValveSoftware:masterfrom
Open
steamcompmgr: Update _NET_WM_STATE when state changes#2069cgutman wants to merge 1 commit intoValveSoftware:masterfrom
cgutman wants to merge 1 commit intoValveSoftware:masterfrom
Conversation
SDL3 depends on receiving a PropertyNotify for _NET_WM_STATE after it sends a ClientMessage to change the window state. If it doesn't receive one within 100 ms, it will assume the change failed and will not set the expected window flag. Therefore, we cannot just silently apply the changes. We must also change the _NET_WM_STATE property, so apps know we actually applied the requested change. Fixes SDL3 windows never getting SDL_WINDOW_FULLSCREEN set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDL3 depends on receiving a
PropertyNotifyfor_NET_WM_STATEafter it sends aClientMessageto change the window state. If it doesn't receive one within 100 ms, it will assume the change failed and will not set the expected window flag. Therefore, we cannot just silently apply the changes. We must also change the_NET_WM_STATEproperty, so apps know we actually applied the requested change.Fixes SDL3 windows never getting
SDL_WINDOW_FULLSCREENset.