Skip to content

[HL][TFC] Fix for a crash while parsing the command menu if the button text is too long #3960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pizzahut2 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[HL][TFC] Fix for a crash while parsing the command menu if the button text is too long #3960

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
869ad38
Potential fix for "CHudTextMessage::LocaliseTextString" in "cl_dll/te…
pizzahut2 Nov 21, 2025
171713b
Update text_message.cpp
pizzahut2 Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cl_dll/text_message.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,17 +72,17 @@ char *CHudTextMessage::LocaliseTextString( const char *msg, char *dst_buffer, in
}

// copy string into message over the msg name
for ( char *wsrc = (char*)clmsg->pMessage; *wsrc != 0; wsrc++, dst++ )
for ( char *wsrc = (char*)clmsg->pMessage; *wsrc != 0 && buffer_size > 0; wsrc++, dst++, buffer_size-- )
{
*dst = *wsrc;
}
*dst = 0;
if ( buffer_size >= 1 ) *dst = 0; // The buffer_size has already been decreased by the amount of data written, so 1 character left is sufficient. No else case is needed because for this case (end of buffer) zero termination is ensured at the end of this function.
}
else
{
*dst = *src;
dst++, src++;
*dst = 0;
if ( buffer_size >= 2 ) *dst = 0; // This is the 2nd byte written. No else case is needed because for this case (end of buffer) zero termination is ensured at the end of this function.
}
}

Expand Down