[All Games; ServerBrowser] Use 64bit time_t instead of 32bit unsigned int to store timestamps #1685
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanyaSho
changed the title
SanyaSho
force-pushed
the
fix/serverbrowser-64bit-time
branch
from
7184b62 to
b32039b
Compare
SanyaSho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently all of Source1 games are using 32bit value to store 64bit timestamps which causes integer overflow and by result displaying a wrong date.
Including these changes will probably require additional code changes in ServerBrowser DLL.
Here's an example of the bug
After the fix
