Skip to content

[TF2] fix explosions being blocked by small protrusions from the ground's geometry (splash bug/stair bug) #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wgetJane wants to merge 3 commits into
base: master
Choose a base branch
from
+70 −2
Open

[TF2] fix explosions being blocked by small protrusions from the ground's geometry (splash bug/stair bug) #1753

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a07e07
fix radius damage being blocked by small steps from the ground
wgetJane Jan 9, 2026
d6af066
remove debug overlay lines
wgetJane Jan 9, 2026
b9844a3
restore debug overlay lines as a cvar
wgetJane Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/game/shared/tf/tf_gamerules.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5781,9 +5781,6 @@ int CTFRadiusDamageInfo::ApplyToEntity( CBaseEntity *pEntity )
UTIL_TraceLine( vecSrc, vecSpot, MASK_RADIUS_DAMAGE, &filterSelf, &tr );
}

NDebugOverlay::Line( tr.startpos, tr.endpos, 255, 0, 0, true, 3 );
Copy link
Contributor

@ficool2 ficool2 Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep these as a convar

Copy link
Contributor Author

@wgetJane wgetJane Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, would be useful i guess

NDebugOverlay::Line( tr.endpos, vecSpot, 96, 0, 0, true, 3 );

// If we don't trace the whole way to the target, and we didn't hit the target entity, we're blocked
if ( tr.fraction != 1.f && tr.m_pEnt != pEntity )
{
Expand All @@ -5809,8 +5806,6 @@ int CTFRadiusDamageInfo::ApplyToEntity( CBaseEntity *pEntity )
trace_t trStep;
UTIL_TraceLine( vecStartPos, vecTarget, MASK_RADIUS_DAMAGE, &filter, &trStep );

NDebugOverlay::Line( trStep.startpos, trStep.endpos, 0, 128, 255, true, 3 );

if ( trStep.fraction == 1.f || trStep.plane.normal.z < 0.7 )
// don't splash if we can't find walkable ground
// this stops Soldiers from splashing high-ground targets by shooting at the edge of the ledge from below
Expand All @@ -5827,14 +5822,9 @@ int CTFRadiusDamageInfo::ApplyToEntity( CBaseEntity *pEntity )
// trace up from the floor to simulate step up
UTIL_TraceLine( vecStartPos, vecTarget, MASK_RADIUS_DAMAGE, &filter, &trStep );

NDebugOverlay::Line( trStep.startpos, trStep.endpos, 0, 255, 255, true, 3 );

// check if explosion can see target from this raised position
UTIL_TraceLine( trStep.endpos, vecSpot, MASK_RADIUS_DAMAGE, &filter, &trStep );

NDebugOverlay::Line( trStep.startpos, trStep.endpos, 0, 255, 0, true, 3 );
NDebugOverlay::Line( trStep.endpos, vecSpot, 0, 128, 0, true, 3 );

if ( trStep.startsolid || trStep.fraction != 1.f && trStep.m_pEnt != pEntity )
// target is still blocked
return 0;
Expand Down