Skip to content

[TF2] Fixed duplicate itemtype line appearing in collection cosmetic descriptions #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rabscootle wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[TF2] Fixed duplicate itemtype line appearing in collection cosmetic descriptions #1755

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/game/shared/econ/econ_item_description.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1263,9 +1263,15 @@ void CEconItemDescription::Generate_ItemLevelDesc_Default( const CLocalizationPr
const bool bIsStoreItem = IsStorePreviewItem( pEconItem );
const bool bIsPreviewItem = pEconItem->GetFlags() & kEconItemFlagClient_Preview;

// For collection cosmetics, we already display itemtype with item grade (ie. "Mercenary Grade Hat")
if (pEconItem->GetItemDefinition()->GetRarity() != k_unItemRarity_Any)
{
return;
}

// If the item doesn't have a valid itemID, we'll just use the locTypename for the item level description.
// We don't want to display "Level 0 Hat" in places like the Mann Co. Store and Armory. We'll just display "Hat".
if ( bIsStoreItem || bIsPreviewItem || pEconItem->GetItemDefinition()->GetRarity() != k_unItemRarity_Any )
if ( bIsStoreItem || bIsPreviewItem )
{
if ( locTypename && *locTypename )
{
Expand Down