sharedgpures.sys: Request less permissions to duplicate handles#308
Open
xzn wants to merge 1 commit intoValveSoftware:bleeding-edgefrom
Open
sharedgpures.sys: Request less permissions to duplicate handles#308xzn wants to merge 1 commit intoValveSoftware:bleeding-edgefrom
xzn wants to merge 1 commit intoValveSoftware:bleeding-edgefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From issue ValveSoftware/Proton#580 (comment)
Upstream wine bug: N/A. sharedgpures.sys and SharedGpuResource is Valve's wine only.
Summary:
PROCESS_ALL_ACCESS is not needed to duplicate handles for the purpose of sharing gpu resources. Requesting it causes OptiScaler's dx11ondx12 to fail on FFXIV (where PROCESS_VM_WRITE is not allowed). Quick tests with OptiScaler in various games seem ok with this change.