Open
Conversation
Member
|
Could you rebase this onto |
Contributor
Author
|
This rebase feels rather dirty I'm not gonna lie. Either way this should bring in all the changes from main. |
NN708
requested changes
Mar 17, 2026
Member
NN708
left a comment
There was a problem hiding this comment.
Thanks for working on this. A rebase is still necessary to maintain a clean, linear commit history. I also suggest splitting the changes into several smaller commits, each focused on a single functional change. This will make the review process much easier and the history more readable.
|
|
||
| var modulesCount int | ||
| var includeDepth int | ||
| var maxIncludeDepth = 1 |
Contributor
Author
There was a problem hiding this comment.
No particular reason other than to test this. Whether or not there are recipes out there that use this or not, we should not restrict this at 1. I'm gonna get back to this in a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is aimed to improve the UX of errors from Vib.
To achieve this, Vib now acts more like a compiler, specifically as in collecting as many as possible errors in stdout before exiting, and giving clearer error messages while doing so.
Some help to get the last few nits picked would be very much welcome and appreciated.
This is mainly set to draft because I only had limited time for error path & happy path testing and would like potential bugs I haven’t noticed to be fixed before a release of Vib.
Changes:
<type of module>] module<module name>of<submodule>included by<including module>:Resolves:
https://discord.com/channels/1023243680829681704/1468666070343618836
Vanilla-OS/custom-image#26
#147
Need ideas for: