Made a script that when you run it will install APX 2.0#261
Closed
GabsEdits wants to merge 6 commits intoVanilla-OS:v2from
Closed
Made a script that when you run it will install APX 2.0#261GabsEdits wants to merge 6 commits intoVanilla-OS:v2from
GabsEdits wants to merge 6 commits intoVanilla-OS:v2from
Conversation
13 tasks
kbdharun
reviewed
May 8, 2024
Member
kbdharun
left a comment
kbdharun
left a comment
There was a problem hiding this comment.
Thanks for your contribution. I have some suggestions for these files.
Contributor
|
We provide a makefile in apx, it would be better to just make the script use that instead. |
Member
Author
I guess it would be better. That would also require me to update the old blog with the new script. This Pull request currently uses the old script that was made when the blog was released, with a few modifications to make the script more user friendly. |
…ocumentation changes Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Member
|
The v2 branch was migrated to the main branch a while ago, If required then this script along with the above suggestions should be proposed for the default branch (main). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From blog, Vanilla-OS/website#104