fix: rename voice to get around circular generation issue #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🌿 Preview your docs: https://vapi-preview-bdaa8222-f722-4dbd-b608-2d79bc1bedd4.docs.buildwithfern.com |
Contributor
|
🌿 Preview your docs: https://vapi-preview-1f8e64da-4b6c-4b88-a9e4-f32f5020796f.docs.buildwithfern.com |
Contributor
|
🌿 Preview your docs: https://vapi-preview-3672786e-ac4f-4364-9118-bb8ff4d059da.docs.buildwithfern.com |
Contributor
|
🌿 Preview your docs: https://vapi-preview-2256d6b9-097c-4b68-839e-a886eb1db12d.docs.buildwithfern.com |
Contributor
|
🌿 Preview your docs: https://vapi-preview-f95b328d-6313-4cc5-ab9b-91e44e238837.docs.buildwithfern.com |
Contributor
|
🌿 Preview your docs: https://vapi-preview-2f4d444b-89f7-41ad-9542-5e47c0970a35.docs.buildwithfern.com |
nikhilro
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a necessary override to
AzureVoice. This sort of override is required everytime Vapi is going to add a voice that containsoneOfwith an enum and a string.Root cause: When there are two
oneOfsthat are not a reference to a component schema, Fern has to make a decision about what to name each variant. In this case, it's not able to come up with a good name so we usex-fern-type-nameto set the name for the generator.