Skip to content

Commit 1cfda4a

Browse files
committed
Disable unit test for Gene Ontology code requirement.
1 parent a569a2c commit 1cfda4a

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

src/mavedb/lib/validation/keywords.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
1-
import re
21
from typing import Optional
32

43
from mavedb.lib.validation.exceptions import ValidationError
54
from mavedb.lib.validation.utilities import is_null
65

76

87
def validate_code(key: str, label: str, code: Optional[str]):
9-
# TODO Re-enable this when we have GO codes for all phenotypic assay mechanisms.
8+
# TODO(#511) Re-enable the Gene Ontology code requirement.
109
pass
1110
# if key.lower() == "phenotypic assay mechanism" and label.lower() != "other":
1211
# # The Gene Ontology accession is a unique seven digit identifier prefixed by GO:.

tests/validation/test_keywords.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,13 @@ def test_Gene_Ontology_valid_accession(self):
4646
code = "GO:1234567"
4747
validate_code(key, label, code)
4848

49-
def test_Gene_Ontology_invalid_accession(self):
50-
key = "Phenotypic Assay Mechanism"
51-
label = "label"
52-
code = "GO:123"
53-
with self.assertRaises(ValidationError):
54-
validate_code(key, label, code)
49+
# TODO(#511) Re-enable the Gene Ontology code requirement.
50+
# def test_Gene_Ontology_invalid_accession(self):
51+
# key = "Phenotypic Assay Mechanism"
52+
# label = "label"
53+
# code = "GO:123"
54+
# with self.assertRaises(ValidationError):
55+
# validate_code(key, label, code)
5556

5657
def test_Gene_Ontoloty_term_is_other(self):
5758
key = "Phenotypic Assay Mechanism"

0 commit comments

Comments
 (0)