Release 2025.1.0 #390
Merged
Release 2025.1.0 #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…missions to view it. The current version to other users will only be the published one.
…score sets are unpublished yet. Haven't fixed the search score set codes.
…dd some related tests.
Urn should not be able to be specified during creation or modification Co-authored-by: Ben Capodanno <[email protected]>
Co-authored-by: Ben Capodanno <[email protected]>
This router exposes limited user information (first name, last name, and username/Orcid ID) to non-admin users. Previously, non-admin users could not look up users at all. Non-self user lookup by non-admin users is necessary for adding users to a collection in the UI. Use Starlette custom type convertor to determine whether the provided ID in the router path is an Orcid ID. If so, limited information about the user will be returned, whether or not the requesting user has admin privileges. If the ID in the router path is an integer (database ID), the previously existing router will be used, which requires admin privileges and returns the full admin view of the user. We may choose to combine these routers in the future, in order to only allow user lookup by Orcid ID/username, unless there is a use case for looking up by database ID. Note that the custom type convertor requires an actual Orcid ID, so usernames that are not Orcid IDs cannot be used for user lookup.
Collection permissions do not distinguish between creator/owner and admin, so automatically assign collection creator as admin for that collection.
Since collection owner is automatically assigned as admin for that collection (see 0ce14cf), do not display owned collections separately from admin collections when fetching a user's collections.
…llections Data collections
…om downloading file. Add some related tests. Failed tests due a bug.
Typo in mock_worker_variant_insertion leads to a wrong counts file path.
…ropDownloadNullHgvsColumns Debug mock_worker_variant_insertion so the tests can pass.
…vsColumns Remove NA columns from dowloading scores and counts files.
…tifierTests Add a PubMed url test.
…coreSet' into estelle/debugShowTmpSupersedingScoreSet
…edingScoreSet Fix current version bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features / Enhancements
Closes #313: #361
Closes #288: #374
Bugfixes
Fixes #330: #331
Fixes #230: #385
Fixes #383: #384
Fixes #386: #387
Fixes #371 and fixes #370: #366
Maintenance