-
Notifications
You must be signed in to change notification settings - Fork 2
Clean and Standardize OpenAPI Documentation #555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bencap
merged 33 commits into
release-2025.5.0
from
maintenance/bencap/542/cleanup-open-api-docs
Nov 11, 2025
Merged
Clean and Standardize OpenAPI Documentation #555
bencap
merged 33 commits into
release-2025.5.0
from
maintenance/bencap/542/cleanup-open-api-docs
Nov 11, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es, explicitly define all responses
…g deletion attempt
…ions for collection routes
…for DOI endpoints
…ary for fetch experiment set endpoint
…tions and summaries for various experiment endpoints
…tion and update log interaction summary
…r mapped variant endpoints
…rove response descriptions for ORCID endpoints
…s for publication identifier endpoints
…dling for search endpoint
…a endpoints, and improve response descriptions for sequence endpoint
…r score set endpoints, and improve error handling for various scenarios
…version endpoints, and improve response descriptions
…ints and improve response descriptions
…h text in target gene identifiers search and add summary text
…r target genes endpoints
…r variant endpoints
Refactor API routers to use shared response definitions and update prefix - Updated all API routers to use the new ROUTER_BASE_PREFIX for consistent URL structure. - Replaced hardcoded response definitions with shared response mappings for better maintainability. - Consolidated error responses into shared constants for easier updates and consistency across routers. - Ensured that all routers now handle authentication and permission errors using the new shared response structure. Refactor HTTP status codes for improved clarity and consistency across various endpoints Update error handling for multiple sequences: change status code to 400 and provide explicit namespace guidance
…documentation and clarity
…avedb-api into maintenance/bencap/542/cleanup-open-api-docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes ballooned a lot from the initial scope, but should reflect a substantial improvement in the quality of our OpenAPI documentation, both in terms of usability and maintainability.
This pull request introduces significant improvements to the API routers and error handling across several modules, focusing on consistent response formatting, clearer documentation, and stricter access control. The changes enhance the maintainability and usability of the API by standardizing route metadata, error responses, and permission checks.
API Router and Metadata Standardization
Access Control and Error Handling
Collection and Resource Management
Improved Logging and Security
Miscellaneous Corrections