fix: mock UTABase fetch in hgvs_genes test for consistent results

src/mavedb/scripts/calibrated_variant_effects.py

@@ -0,0 +1,185 @@
+"""
+Count unique variant effect measurements within ACMG-classified functional ranges.
+
+This script analyzes MaveDB score sets to count how many variant effect measurements
+have functional scores that fall within score calibration ranges associated with
+ACMG (American College of Medical Genetics) classifications. The analysis provides
+insights into how many variants can be clinically interpreted using established
+evidence strength frameworks.
+
+Usage:
+    # Show help and available options
+    with_mavedb_local poetry run python3 -m mavedb.scripts.effect_measurements --help
+
+    # Run in dry-run mode (default, no database changes, shows results)
+    with_mavedb_local poetry run python3 -m mavedb.scripts.effect_measurements --dry-run
+
+    # Run and commit results (this script is read-only, so commit doesn't change anything)
+    with_mavedb_local poetry run python3 -m mavedb.scripts.effect_measurements --commit
+
+Behavior:
+    1. Queries all non-superseded score sets that have score calibrations
+    2. Identifies calibrations with functional ranges that have ACMG classifications
+    3. For each qualifying score set, queries its variants with non-null scores
+    4. Counts variants whose scores fall within ACMG-classified ranges
+    5. Reports statistics on classification coverage
+
+Key Filters:
+    - Excludes superseded score sets (where superseding_score_set is not None)
+    - Only processes score sets that have at least one score calibration
+    - Only considers functional ranges with ACMG classification data
+    - Only counts variants that have non-null functional scores
+    - Each variant is counted only once per score set, even if it matches multiple ranges
+
+ACMG Classification Detection:
+    A functional range is considered to have an ACMG classification if its
+    acmg_classification field contains any of:
+    - criterion (PS3, BS3, etc.)
+    - evidence_strength (Supporting, Moderate, Strong, Very Strong)
+    - points (numeric evidence points)
+
+Performance Notes:
+    - Uses optimized queries to avoid loading unnecessary data
+    - Loads score sets and calibrations first, then queries variants separately
+    - Filters variants at the database level for better performance
+    - Memory usage scales with the number of score sets with ACMG ranges
+
+Output:
+    - Progress updates for each score set with classified variants
+    - Summary statistics including:
+      * Number of score sets with ACMG classifications
+      * Total unique variants processed
+      * Number of variants within ACMG-classified ranges
+      * Overall classification rate percentage
+
+Caveats:
+    - This is a read-only analysis script (makes no database changes)
+    - Variants with null/missing scores are included in the analysis
+"""
+
+import logging
+from typing import Set
+
+import click
+from sqlalchemy import select
+from sqlalchemy.orm import Session, joinedload
+
+from mavedb.models.score_set import ScoreSet
+from mavedb.scripts.environment import with_database_session
+from mavedb.view_models.score_calibration import FunctionalRange
+
+logger = logging.getLogger(__name__)
+
+
+def score_falls_within_range(score: float, functional_range: dict) -> bool:
+    """Check if a score falls within a functional range using the view model."""
+    try:
+        range_obj = FunctionalRange.model_validate(functional_range)
+        return range_obj.is_contained_by_range(score)
+    except Exception as e:
+        logger.warning(f"Error validating functional range: {e}")
+        return False
+
+
+def has_acmg_classification(functional_range: dict) -> bool:
+    """Check if a functional range has an ACMG classification."""
+    acmg_data = functional_range.get("acmg_classification")
+    return acmg_data is not None and (
+        acmg_data.get("criterion") is not None
+        or acmg_data.get("evidence_strength") is not None
+        or acmg_data.get("points") is not None
+    )
+
+
+@click.command()
+@with_database_session
+def main(db: Session) -> None:
+    """Count unique variant effect measurements with ACMG-classified functional ranges."""
+
+    query = (
+        select(ScoreSet)
+        .options(joinedload(ScoreSet.score_calibrations))
+        .where(ScoreSet.private.is_(False))  # Public score sets only
+        .where(ScoreSet.superseded_score_set_id.is_(None))  # Not superseded
+        .where(ScoreSet.score_calibrations.any())  # Has calibrations
+    )
+
+    score_sets = db.scalars(query).unique().all()
+
+    total_variants = 0
+    classified_variants = 0
+    score_sets_with_acmg = 0
+    processed_variants: Set[int] = set()
+    gene_list: Set[str] = set()
+
+    click.echo(f"Found {len(score_sets)} non-superseded score sets with calibrations")
+
+    for score_set in score_sets:
+        # Collect all ACMG-classified ranges from this score set's calibrations
+        acmg_ranges = []
+        for calibration in score_set.score_calibrations:
+            if calibration.functional_ranges:
+                for func_range in calibration.functional_ranges:
+                    if has_acmg_classification(func_range):
+                        acmg_ranges.append(func_range)
+
+        if not acmg_ranges:
+            continue
+
+        score_sets_with_acmg += 1
+        score_set_classified_variants = 0
+
+        # Retain a list of unique target genes for reporting
+        for target in score_set.target_genes:
+            target_name = target.name
+            if not target_name:
+                continue
+
+            gene_list.add(target_name.strip().upper())
+
+        for variant in score_set.variants:
+            if variant.id in processed_variants:
+                continue
+
+            variant_data = variant.data
+            if not variant_data:
+                continue
+
+            score_data = variant_data.get("score_data", {})
+            score = score_data.get("score")
+
+            total_variants += 1
+            processed_variants.add(variant.id)  # type: ignore
+
+            if score is None:
+                continue
+
+            # Check if score falls within any ACMG-classified range in this score set
+            for func_range in acmg_ranges:
+                if score_falls_within_range(float(score), func_range):
+                    classified_variants += 1
+                    score_set_classified_variants += 1
+                    break  # Count variant only once per score set
+
+        if score_set_classified_variants > 0:
+            click.echo(
+                f"Score set {score_set.urn}: {score_set_classified_variants} classified variants ({score_set.num_variants} total variants)"
+            )
+
+    click.echo("\n" + "=" * 60)
+    click.echo("SUMMARY")
+    click.echo("=" * 60)
+    click.echo(f"Score sets with ACMG classifications: {score_sets_with_acmg}")
+    click.echo(f"Total unique variants processed: {total_variants}")
+    click.echo(f"Variants within ACMG-classified ranges: {classified_variants}")
+    click.echo(f"Unique target genes covered ({len(gene_list)}):")
+    for gene in sorted(gene_list):
+        click.echo(f" - {gene}")
+
+    if total_variants > 0:
+        percentage = (classified_variants / total_variants) * 100
+        click.echo(f"Classification rate: {percentage:.1f}%")
+
+
+if __name__ == "__main__":  # pragma: no cover
+    main()

tests/routers/test_hgvs.py

@@ -10,7 +10,9 @@
 fastapi = pytest.importorskip("fastapi")
 hgvs = pytest.importorskip("hgvs")
 
-from tests.helpers.constants import TEST_NT_CDOT_TRANSCRIPT, VALID_NT_ACCESSION, VALID_GENE
+from hgvs.dataproviders.uta import UTABase
+
+from tests.helpers.constants import TEST_NT_CDOT_TRANSCRIPT, VALID_GENE, VALID_NT_ACCESSION
 
 VALID_MAJOR_ASSEMBLY = "GRCh38"
 VALID_MINOR_ASSEMBLY = "GRCh38.p3"
@@ -85,9 +87,12 @@ def test_hgvs_accessions_invalid(client, setup_router_db):
 
 
 def test_hgvs_genes(client, setup_router_db):
-    response = client.get("/api/v1/hgvs/genes")
-    assert response.status_code == 200
-    assert VALID_GENE in response.json()
+    with patch.object(UTABase, "_fetchall") as mock_fetchall:
+        mock_fetchall.return_value = (("BRCA1",), ("TP53",), (VALID_GENE,))
+
+        response = client.get("/api/v1/hgvs/genes")
+        assert response.status_code == 200
+        assert VALID_GENE in response.json()
 
 
 def test_hgvs_gene_info_valid(client, setup_router_db):