Score set search result optimization #493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jstone-dev
commented
Sep 30, 2025
jstone-dev
commented
- Consume the revised score set search endpoints, which return total result counts along with results.
- Obtain score set search filter options from a separate API request.
jstone-dev
changed the title
bencap
approved these changes
Oct 1, 2025
Collaborator
bencap
left a comment
bencap
left a comment
There was a problem hiding this comment.
Looks good pending any changes from the API side of things.
| }, | ||
| fetchFilterOptions: async function () { | ||
| try { | ||
| const requestParams: SearchParams = { |
Collaborator
There was a problem hiding this comment.
I think it'd be nice (although not necessary) to explicitly define the limit here. Should we eventually overhaul the search we could revisit the value but to me an explicit limit here is just an improvement in every case. There's no reason to ever have a result set that's 3000 score sets long on a single page (and I'm sure Alan would thank us 😄).
Depending on what you think about the page suggestion from VariantEffect/mavedb-api#525 (review) we would also add that here along with a next/previous UI element.
Retrieves AlphaFold model version from API to be included in CIF file URL, rather than hardcoding, to prevent 404s when old file versions are purged by AlphaFold. Goes with [#VariantEffect/mavedb-api/davereinhart/alphafold-files-version-proxy](VariantEffect/mavedb-api@590844e)
…h terms - Adds support for ClinGen allele IDs, dbSNP rs IDs, and ClinVar Variation IDs. - Dynamically determine search type based on search term and make appropriate request to ClinGen Allele Registry - Add examples to page for newly supported search terms - Support return of multiple alleles from ClinGen Allele Registry request
… scroll to results div after search
… AlphaFold version # and structure files
…fold-cif-version ProteinStructureView: dynamic AlphaFold model file version
…rror message generation - Adds fixed width to search type dropdown - Add search examples to searchTypeOptions for dynamic generation of HTML elements and error messages displayed via toast - Add support for seaching via dbSNP rs IDs without rs prefix
…-options Add MaveMd search options for ClinGen Allele IDs, dbSNP rs IDs, and ClinVar Variation IDs
…sult counts along with results.
The search endpoint now returns a limited set of results, so a complete list of options for further filtering the result set cannot be obtained from the result set.
jstone-dev
force-pushed
the
jstone-dev/score-set-search-result-optimization
branch
from
30a06b9 to
782095d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.