Skip to content

trace_api_plugin enhancements#109

Open
heifner wants to merge 1 commit intomainfrom
heifner-patch-1
Open

trace_api_plugin enhancements#109
heifner wants to merge 1 commit intomainfrom
heifner-patch-1

Conversation

@heifner
Copy link

@heifner heifner commented Oct 28, 2022

No description provided.


## Use SQLite for storage

Usage would simplify the index on transaction issue and provide easier storage/lookup of ABI. Also solves the `fsync` question.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it solve it or just move it? I thought (by default) a transaction in sqlite implies an fsync. So if, for example, we do an sqlite transaction for each block, it'd be no different in fsync overhead as before.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.sqlite.org/pragma.html#pragma_synchronous
By default fsync is still used. So move is a better description. It does look like it can be smarter about the fsync than our current implementation. Although, our current implementation likely doesn't even need it.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we use "journal_mode=WAL" and "synchronous=normal" this should reduce fsync to only when the WAL is checkpointing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From our 11/8/2022 conversation on this topic:

  • need to understand potential impacts on transaction processing time
  • might explore alternative proposal adding filtering capabilities to SHiP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants