Skip to content

Fix potential client memory leak in ManaNetworkHandler #4947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheRealWormbo merged 1 commit into from
Oct 25, 2025
Merged

Fix potential client memory leak in ManaNetworkHandler #4947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Xplat/src/main/java/vazkii/botania/common/handler/ManaNetworkHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ private <T> void remove(Map<Level, Set<T>> map, Level level, T thing) {
}

private <T> void add(Map<Level, Set<T>> map, Level level, T thing) {
map.computeIfAbsent(level, k -> new HashSet<>()).add(thing);
map.computeIfAbsent(level, k -> Collections.newSetFromMap(new WeakHashMap<>())).add(thing);
}

@Override
Expand Down
1 change: 1 addition & 0 deletions web/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ In the meantime, Botania for Minecraft 1.20.1 may still receive updates for bug
* Fix: Don't let Alfheim portal grab items in the tick it shuts down (e.g. for gluten reasons)
* Fix: Astrolabe no longer attempts to place blocks in the player's head location while underwater
* Fix: Mana bursts going through a nether portal could cause lag spikes
* Fix: Potential client memory leak in ManaNetworkHandler

---

Expand Down