Extra-lazy parsing for custom book items#793
Merged
artemisSystem merged 3 commits intoVazkiiMods:1.21.xfrom Aug 2, 2025
Merged
Extra-lazy parsing for custom book items#793artemisSystem merged 3 commits intoVazkiiMods:1.21.xfrom
artemisSystem merged 3 commits intoVazkiiMods:1.21.xfrom
Conversation
4fe81c7 to
ad88da3
Compare
Since parsing uses registry-based vanilla logic now, it will not work before the book's mod has finished loading. Fixes VazkiiMods#790 at the expense of potentially delayed error reporting.
ad88da3 to
fde9c95
Compare
Contributor
Author
|
Tested against https://github.com/TheRealWormbo/Botania/tree/1.21.1-patchouli-snapshot – Botania's boot item still works and opens the book, even though Patchouli fails to parse the item string. Example exception: |
Member
|
The comment above parsed probably doesn't apply anymore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since parsing uses registry-based vanilla logic now, it will not work before the book's mod has finished loading.
Fixes #790 at the expense of potentially delayed error reporting.