Fallback to Class.forName when the serviceloader isn't working#801
Fallback to Class.forName when the serviceloader isn't working#801quat1024 wants to merge 3 commits intoVazkiiMods:1.21.xfrom
Conversation
|
my boy has failed spotless, i forgot yall are actually ontop of the formatting in this repo lol. ok gimme a sec |
|
code looks fine by me but i can't build it locally because the neoforge gradle plugin we're using seems to just not work on macos. |
Hopefully fixes VazkiiMods#792, VazkiiMods#795, and VazkiiMods#797, superseding the workaround in PR VazkiiMods#801.
|
Superseded by #818 |
Hello, as the maintainer of the plugin, I am interested to know what does not work. We have over 100 tests in NGs repository that all run and pass on MacOS at the moment, but I am sure I missed something. Could you provide me with more information? |
|
@marchermans I think the issue is only on apple silicon. It tries to download |
Hopefully fixes VazkiiMods#792, VazkiiMods#795, and VazkiiMods#797, superseding the workaround in PR VazkiiMods#801.
see #792, #795, #797, #800.
This is a really stupid fix, it's duct-tape, I just want the mod to stop crashing on people's computers. Nothing should ever break ServiceLoader.
Still logs an exception that the serviceloader failed. If Class.forName also somehow fails for both the fabric and forge classes, it will throw the exception.