Discard the recipe digestion map after firing the event#69
Open
embeddedt wants to merge 1 commit intoVazkiiMods:mainfrom
Open
Discard the recipe digestion map after firing the event#69embeddedt wants to merge 1 commit intoVazkiiMods:mainfrom
embeddedt wants to merge 1 commit intoVazkiiMods:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a faster & simpler alternative to #68 that simply discards the contents of the map after firing
ZRecipeCrawl.Digestinstead of trying to compact them for long-term storage.A defensive copy is made before providing the multimaps to the event; this is for backwards compatibility in case there are mods that just store a reference to the map and assume they can work off of it till receiving the event again. If preserving that behavior is not a requirement, the defensive copy can be removed.
The memory savings should be at least as good as #68 if not better, as now the map doesn't need to be kept in memory long-term at all. In ATM9 this saves about 400MB of memory. 👀