Fix race condition in ForgeZetaEventBus (#52)#80
Open
MauveAvenger wants to merge 1 commit intoVazkiiMods:1.20from
Open
Fix race condition in ForgeZetaEventBus (#52)#80MauveAvenger wants to merge 1 commit intoVazkiiMods:1.20from
MauveAvenger wants to merge 1 commit intoVazkiiMods:1.20from
Conversation
Replace Object2ObjectOpenHashMap with ConcurrentHashMap to prevent race condition during concurrent mod loading. The non-thread-safe fastutil map was being accessed from multiple modloading-worker threads simultaneously, causing ArrayIndexOutOfBoundsException during rehash operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ForgeZetaEventBus.convertedHandlersusesObject2ObjectOpenHashMapwhich is not thread-safe. During mod loading with many mods (370+), concurrent calls tosubscribeMethod()andunsubscribeMethod()can corrupt the map, causing:Relates to #52
Fix
Replace
Object2ObjectOpenHashMapwithConcurrentHashMap. This is a minimal change that makes the map operations thread-safe without changing the API or behavior.Testing
Alternatives Considered
ConcurrentHashMapis cleanerHappy to adjust the approach if you'd prefer something different.