Skip to content

Commit c79af77

Browse files
noonefuzyll
authored andcommitted
Differentiate some enums in IL switch statement
This makes it easier to see which instructions still need to be lifted versus those which never should be lifted.
1 parent 5d75e51 commit c79af77

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

arch/mips/il.cpp

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2114,13 +2114,9 @@ bool GetLowLevelILForInstruction(Architecture* arch, uint64_t addr, LowLevelILFu
21142114
//unimplemented system functions
21152115
case MIPS_BC1ANY2:
21162116
case MIPS_BC1ANY4:
2117-
case MIPS_BSHFL:
21182117
case MIPS_C2:
21192118
case MIPS_CFC1:
21202119
case MIPS_CFC2:
2121-
case MIPS_COP0:
2122-
case MIPS_COP1:
2123-
case MIPS_COP1X:
21242120
case MIPS_COP2:
21252121
case MIPS_COP3:
21262122
case MIPS_CTC1:
@@ -2146,6 +2142,17 @@ bool GetLowLevelILForInstruction(Architecture* arch, uint64_t addr, LowLevelILFu
21462142
case MIPS_SWXC1:
21472143
il.AddInstruction(il.Unimplemented());
21482144
break;
2145+
2146+
// instructions that are just internal placeholders for other
2147+
// decode tables; these will never be implemented because they're
2148+
// not real instructions
2149+
case MIPS_BSHFL:
2150+
case MIPS_COP0:
2151+
case MIPS_COP1:
2152+
case MIPS_COP1X:
2153+
il.AddInstruction(il.Undefined());
2154+
break;
2155+
21492156
default:
21502157
il.AddInstruction(il.Unimplemented());
21512158
break;

0 commit comments

Comments
 (0)