Merged
Conversation
Contributor
Author
|
Newest commit added |
negasora
requested changes
Jul 1, 2025
Member
negasora
left a comment
negasora
left a comment
There was a problem hiding this comment.
Also GetFileByPathInProject and equivalent should be pluralized (GetFilesByPathInProject) since they return a vector/list
spoonmilk
force-pushed
the
test_triage_project_filenames
branch
from
997a35a to
78ae7be
Compare
spoonmilk
force-pushed
the
test_triage_project_filenames
branch
from
78ae7be to
81af8fe
Compare
negasora
approved these changes
Jul 3, 2025
spoonmilk
force-pushed
the
test_triage_project_filenames
branch
from
81af8fe to
df4cb16
Compare
spoonmilk
force-pushed
the
test_triage_project_filenames
branch
from
df4cb16 to
533b8e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds GetPathInProject() function to core API, returning the path of a file in a project relative to the project rather than the actual location on disk.