Change return type of parse_types_from_string to BasicTypeParserResult #7067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plafosse
approved these changes
Jul 10, 2025
spoonmilk
force-pushed
the
fix_typeparser_annotation_type
branch
from
24bcec7 to
7a1a20e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of August 2022, TypeParserResult was changed so that types, variables, functions were lists of ParsedTypes, with functions like parse_types_from_source returning BasicTypeParserResults instead. This changes the signature of parse_types_from_string to reflect this change.
Closes #6833