Add an API to explicitly create the debug adapter object

Author: xusheng6

api/debuggerapi.h

@@ -337,6 +337,8 @@ namespace BinaryNinjaDebuggerAPI
 
         BinaryNinja::Ref<Metadata> GetAdapterProperty(const std::string& name);
         bool SetAdapterProperty(const std::string& name, const BinaryNinja::Ref<Metadata>& value);
+
+		bool ActivateDebugAdapter();
 	};
 
 

api/debuggercontroller.cpp

@@ -680,3 +680,9 @@ bool DebuggerController::SetAdapterProperty(const std::string& name, const Binar
 {
     return BNDebuggerSetAdapterProperty(m_object, name.c_str(), value->m_object);
 }
+
+
+bool DebuggerController::ActivateDebugAdapter()
+{
+	return BNDebuggerActivateDebugAdapter(m_object);
+}

api/ffi.h

@@ -383,6 +383,8 @@ extern "C"
 	DEBUGGER_FFI_API char* BNDebuggerGetStopReasonString(BNDebugStopReason reason);
 	DEBUGGER_FFI_API BNDebugStopReason BNDebuggerGetStopReason(BNDebuggerController* controller);
 
+	DEBUGGER_FFI_API bool BNDebuggerActivateDebugAdapter(BNDebuggerController* controller);
+
 	// DebugAdapterType
 	DEBUGGER_FFI_API BNDebugAdapterType* BNGetDebugAdapterTypeByName(const char* name);
 	DEBUGGER_FFI_API bool BNDebugAdapterTypeCanExecute(BNDebugAdapterType* adapter, BNBinaryView* data);

core/adapters/lldbadapter.cpp

@@ -1149,7 +1149,7 @@ Ref<Metadata> LldbAdapter::GetProperty(const std::string &name)
 	if (name == "current_platform")
 	{
 		auto platform = m_debugger.GetSelectedPlatform();
-		return new Metadata(platform.GetName());
+		return new Metadata(std::string(platform.GetName()));
 	}
 	else if (name == "platforms")
 	{

core/debuggercontroller.cpp

@@ -1492,3 +1492,9 @@ bool DebuggerController::SetAdapterProperty(const std::string& name, const Binar
 {
     return true;
 }
+
+
+bool DebuggerController::ActivateDebugAdapter()
+{
+	return CreateDebugAdapter();
+}

core/debuggercontroller.h

@@ -229,5 +229,7 @@ namespace BinaryNinjaDebugger
 
         BinaryNinja::Ref<BinaryNinja::Metadata> GetAdapterProperty(const std::string& name);
         bool SetAdapterProperty(const std::string& name, const BinaryNinja::Ref<BinaryNinja::Metadata>& value);
+
+		bool ActivateDebugAdapter();
 	};
 };

core/ffi.cpp

@@ -832,3 +832,9 @@ DEBUGGER_FFI_API bool BNDebuggerSetAdapterProperty(BNDebuggerController* control
 {
     return controller->object->SetAdapterProperty(name, new Metadata(BNNewMetadataReference(value)));
 }
+
+
+bool BNDebuggerActivateDebugAdapter(BNDebuggerController* controller)
+{
+	return controller->object->ActivateDebugAdapter();
+}

ui/debugserversetting.cpp

@@ -36,6 +36,9 @@ DebugServerSettingsDialog::DebugServerSettingsDialog(QWidget* parent, DebuggerCo
     titleLayout->setContentsMargins(0, 0, 0, 0);
 
     m_platformEntry = new QComboBox(this);
+	// workaround for the missing Metadata API
+	m_platformEntry->setEditable(true);
+
 //    auto platformsMetaData = m_controller->GetAdapterProperty("platforms");
 //    if (platformsMetaData->IsStringList())
 //    {

ui/ui.cpp

@@ -444,6 +444,27 @@ void GlobalDebuggerUI::SetupMenu(UIContext* context)
     }, connectedToDebugServer));
     debuggerMenu->addAction("Disconnect from Debug Server", "Launch");
 
+	UIAction::registerAction("Activate Debug Adapter");
+	context->globalActions()->bindAction("Activate Debug Adapter", UIAction([=](const UIActionContext& ctxt) {
+		if (!ctxt.binaryView)
+			return;
+		auto controller = DebuggerController::GetController(ctxt.binaryView);
+		if (!controller)
+			return;
+
+		if (controller->ActivateDebugAdapter())
+        {
+            QMessageBox::information(context->mainWindow(), "Successfully activated",
+                                     "Successfully activated the debug adapter. Now you can run backend commands directly.");
+        }
+		else
+        {
+            QMessageBox::information(context->mainWindow(), "Failed to activate",
+                                     "Cannot activate to the debug adapter.");
+        }
+	}));
+	debuggerMenu->addAction("Activate Debug Adapter", "Launch");
+
 #ifdef WIN32
     UIAction::registerAction("Reinstall DbgEng Redistributable");
     context->globalActions()->bindAction("Reinstall DbgEng Redistributable", UIAction([=](const UIActionContext& ctxt) {