Skip to content

Conversation

@amrit110
Copy link
Member

@amrit110 amrit110 commented Nov 2, 2025

This pull request updates the onboarding CLI to require an explicit path to the integration test script, improving clarity and flexibility for users. The main changes involve modifying the _run_tests_and_finalize function to take the test script path as an argument and updating the CLI to require this argument.

Integration Test Script Handling:

  • The _run_tests_and_finalize function now takes a test_script argument, allowing the test script path to be specified externally instead of being hardcoded. [1] [2]
  • The function now checks for the existence of the test script at the provided path and returns an error if the script is not found, improving error handling and user feedback.

CLI Argument Updates:

  • The CLI now requires a --test-script argument, making the integration test script path a mandatory input for the onboarding process.
  • The call to _run_tests_and_finalize in the main function is updated to pass the user-supplied test script path.

@amrit110 amrit110 self-assigned this Nov 2, 2025
@amrit110 amrit110 added the bug Something isn't working label Nov 2, 2025
@amrit110 amrit110 merged commit 93048ed into main Nov 2, 2025
3 checks passed
@amrit110 amrit110 deleted the add_test_file_path branch November 2, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants