Fix bug with case sensitivity tied to github handles #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request standardizes the handling of GitHub handles throughout the codebase by normalizing them to lowercase. This ensures case-insensitive matching for all Firestore lookups and API payloads, reducing potential issues caused by case differences in GitHub usernames. The changes affect both the backend service and utility functions.
GitHub handle normalization:
normalize_github_handleinsrc/aieng_platform_onboard/utils.pyto convert GitHub handles to lowercase for consistent lookups.get_participant_data,check_onboarded_status, andupdate_onboarded_statusto use normalized GitHub handles, ensuring case-insensitive document retrieval and updates. [1] [2] [3]fetch_token_from_serviceto send the normalized GitHub handle to the backend API.Backend service update:
get_github_handle_from_workspace_sainservices/token-service/main.pyto normalize GitHub handles before Firestore lookups and in return values, ensuring consistent participant identification. [1] [2]