Fix bugs to compute active hours #46
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the accuracy of active hours aggregation in analytics metrics by introducing a new function to correctly sum user active hours across workspaces. The main change ensures that active hours are not overcounted for users with multiple workspaces, and that each user's active hours are capped at their total workspace hours. This logic is now consistently applied in team and template metrics calculations. Additionally, a clarifying comment was added to the backend script to explain the semantics of active hours.
Active hours aggregation improvements:
calculateTotalActiveHoursfunction inmetrics.tsto aggregate active hours per user, capping each user's active hours at their total workspace hours to prevent overcounting.aggregateByTeamto use the new aggregation logic for total active hours, replacing the previous simple sum.calculateTemplateMetricsto use the new aggregation logic for total active hours, ensuring consistency across analytics.Documentation and clarity:
collect_coder_analytics.pyexplaining thatactive_hoursis per-user (not per-workspace) and that frontend aggregation counts each user only once.