Skip to content

Comments

v0.5.0#78

Merged
XkunW merged 193 commits intomainfrom
develop
Mar 20, 2025
Merged

v0.5.0#78
XkunW merged 193 commits intomainfrom
develop

Conversation

@XkunW
Copy link
Contributor

@XkunW XkunW commented Mar 20, 2025

PR Type

[Release]

Short Description

  • Decouple model config from repo, the config priority is the following descending order: user-defined config, cached config, default config
  • Code base refactor, command logic moved to helper classes
  • Retire launch server bash script, moved server launching logic to python
  • Update metrics command to use metrics API endpoint
  • Exposed additional launch parameters for CLI
  • Automate docker image build process and pushing to dockerhub
  • Improve the dev build tooling (migrate to uv from poetry)
  • Reduce maintenance overhead by having dependabot submit security updates and dependency updates as long as they conform to the requirements of the library
  • Added unit tests for _cli.py, _utils.py, and imports
  • Add server launch info json to logging
  • Misc house-keeping fixes
  • Onboarded various new models (VLM, Reward Modelling models)

Tests Added

  • test_cli.py:
    • test_launch_command_success
    • test_launch_command_with_json_output
    • test_launch_command_model_not_in_config_with_weights
    • test_launch_command_model_not_found
    • test_list_all_models
    • test_list_single_model
    • test_metrics_command_pending_server
    • test_metrics_command_server_not_ready
    • test_metrics_command_server_ready
    • test_metrics_command_request_failed
  • test_utils.py:
    • test_run_bash_command_success
    • test_run_bash_command_error
    • test_read_slurm_log_found
    • test_read_slurm_log_not_found
    • test_is_server_running_statuses
    • test_get_base_url_found
    • test_get_base_url_not_found
    • test_model_health_check
    • test_model_health_check_request_exception
    • test_create_table_with_header
    • test_create_table_without_header
    • test_load_config_default_only
    • test_load_config_with_user_override
    • test_load_config_invalid_user_model
  • test_imports.py:
    • test_import_cli_modules

amrit110 and others added 30 commits February 14, 2025 15:07
Bumps [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) from 1.4.2 to 1.12.4.
- [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases)
- [Commits](pypa/gh-action-pypi-publish@27b3170...76f52bc)

---
updated-dependencies:
- dependency-name: pypa/gh-action-pypi-publish
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.0.0 to 5.4.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v5...v5.4.0)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [pypa/gh-action-pip-audit](https://github.com/pypa/gh-action-pip-audit) from 1.0.8 to 1.1.0.
- [Release notes](https://github.com/pypa/gh-action-pip-audit/releases)
- [Commits](pypa/gh-action-pip-audit@v1.0.8...v1.1.0)

---
updated-dependencies:
- dependency-name: pypa/gh-action-pip-audit
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.1 to 4.2.2.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4.1.1...v4.2.2)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…/pypa/gh-action-pypi-publish-1.12.4

Bump pypa/gh-action-pypi-publish from 1.4.2 to 1.12.4
…/pypa/gh-action-pip-audit-1.1.0

Bump pypa/gh-action-pip-audit from 1.0.8 to 1.1.0
…/actions/setup-python-5.4.0

Bump actions/setup-python from 5.0.0 to 5.4.0
…/actions/checkout-4.2.2

Bump actions/checkout from 4.1.1 to 4.2.2
XkunW and others added 25 commits March 19, 2025 15:41
… models, remove default fields in model config, fixed a wrong model family name
* Onboard new VLM models 
* Add prefix cache hit rate metric to metrics command
@XkunW XkunW requested review from amrit110 and jwilles March 20, 2025 20:04
Copy link
Contributor

@jwilles jwilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@XkunW XkunW merged commit 45ef380 into main Mar 20, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants