Skip to content

Use enable/disable flags in CLI options#85

Closed
fcogidi wants to merge 1 commit intomainfrom
fco/improve_bool_flags
Closed

Use enable/disable flags in CLI options#85
fcogidi wants to merge 1 commit intomainfrom
fco/improve_bool_flags

Conversation

@fcogidi
Copy link
Contributor

@fcogidi fcogidi commented Apr 8, 2025

PR Type

Fix.

Short Description

I ran into an issue where I needed to disable pipeline parallelism, which was set by default in the model config. (In my usecase, it messes with structured outputs). I disabled pipeline parallelism in the model config and used the slash syntax in click so allow for explicitly overriding the option (and similar boolean flags) from the command line.

Tests Added

None.

@fcogidi fcogidi requested review from XkunW, amrit110 and Copilot April 8, 2025 18:20
@fcogidi fcogidi self-assigned this Apr 8, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.06%. Comparing base (38a4fa7) to head (28650cc).
Report is 247 commits behind head on main.

Files with missing lines Patch % Lines
vec_inf/cli/_helper.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #85   +/-   ##
=======================================
  Coverage   79.06%   79.06%           
=======================================
  Files           4        4           
  Lines         554      554           
=======================================
  Hits          438      438           
  Misses        116      116           
Files with missing lines Coverage Δ
vec_inf/cli/_cli.py 83.15% <ø> (ø)
vec_inf/cli/_config.py 100.00% <ø> (ø)
vec_inf/cli/_helper.py 73.76% <50.00%> (ø)

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from develop to main April 10, 2025 14:26
@fcogidi fcogidi closed this Apr 15, 2025
@fcogidi fcogidi deleted the fco/improve_bool_flags branch April 15, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments