-
Notifications
You must be signed in to change notification settings - Fork 12
Feature/disable home mount #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
=======================================
Coverage 82.39% 82.39%
=======================================
Files 12 12
Lines 835 835
=======================================
Hits 688 688
Misses 147 147
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
vec_inf/client/_slurm_script_generator.py:190
- The variable 'self.model_weights_path' is referenced but not defined in the class. Ensure it is properly initialized before being used.
f" singularity exec --nv --bind {self.model_weights_path}:{self.model_weights_path} "
vec_inf/client/_slurm_script_generator.py:233
- The variable 'self.model_weights_path' is referenced in the launcher method without any visible initialization. Consider initializing or passing this value to avoid runtime errors.
f"""singularity exec --nv --bind {self.model_weights_path}:{self.model_weights_path} --containall $SINGULARITY_IMAGE \"""
jwilles
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Type
[Feature]
Short Description