Skip to content

Conversation

@XkunW
Copy link
Contributor

@XkunW XkunW commented Apr 11, 2025

PR Type

[Feature]

Short Description

  • Disable singularity automatic home directory mounting as this behaviour tend to cause issues if user's home directory has conflicting environment variables
  • Minor refactoring for slurm script generator for better readability, added doc strings

@XkunW XkunW requested review from Copilot and jwilles April 11, 2025 17:10
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.39%. Comparing base (4a2e8aa) to head (52bf94a).
Report is 158 commits behind head on main.

Files with missing lines Patch % Lines
vec_inf/client/_slurm_script_generator.py 42.85% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #88   +/-   ##
=======================================
  Coverage   82.39%   82.39%           
=======================================
  Files          12       12           
  Lines         835      835           
=======================================
  Hits          688      688           
  Misses        147      147           
Files with missing lines Coverage Δ
vec_inf/client/_slurm_script_generator.py 75.34% <42.85%> (ø)

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

vec_inf/client/_slurm_script_generator.py:190

  • The variable 'self.model_weights_path' is referenced but not defined in the class. Ensure it is properly initialized before being used.
f"    singularity exec --nv --bind {self.model_weights_path}:{self.model_weights_path} "

vec_inf/client/_slurm_script_generator.py:233

  • The variable 'self.model_weights_path' is referenced in the launcher method without any visible initialization. Consider initializing or passing this value to avoid runtime errors.
f"""singularity exec --nv --bind {self.model_weights_path}:{self.model_weights_path} --containall $SINGULARITY_IMAGE \"""

Copy link
Contributor

@jwilles jwilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XkunW XkunW requested a review from amrit110 April 15, 2025 21:11
@XkunW XkunW merged commit 14a7776 into main Apr 21, 2025
7 checks passed
@XkunW XkunW deleted the feature/disable_home_mount branch April 21, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants