Skip to content

Conversation

@amrit110
Copy link
Member

@amrit110 amrit110 commented Apr 16, 2025

PR Type

Documentation, enhancement

Short Description

  • Add support for multi-version docs hosted via github pages
  • Remove the develop branch references in the github workflows, we are not using a develop branch anymore
  • Every time there is a PR, the building of docs happens in CI, but nothing is deployed. The main branch documentation is tagged as "main", while releases create a versioned doc with the "latest" alias for the latest one.

To test locally:

  1. uv sync --dev --group docs
  2. mike deploy 0.5.0 latest
  3. mike deploy main
  4. mike set-default 0.5.0
  5. mike serve

Note that previous versions like 0.4.0, etc won't have docs. We would have to manually add them if needed.

@amrit110 amrit110 added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 16, 2025
@amrit110 amrit110 requested a review from Copilot April 16, 2025 17:25
@amrit110 amrit110 self-assigned this Apr 16, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • docs/stylesheets/extra.css: Language not supported

amrit110 and others added 3 commits April 16, 2025 13:26
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…itute/vector-inference into add_multiversion_docs_support
@amrit110 amrit110 requested a review from Copilot April 16, 2025 18:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • docs/stylesheets/extra.css: Language not supported
Comments suppressed due to low confidence (1)

.github/workflows/docs.yml:144

  • The regex used to extract the version from pyproject.toml may fail if additional whitespace or formatting changes occur. Consider using a dedicated TOML parser for more robust version extraction.
VERSION=$(grep -m 1 '^version = ' pyproject.toml | sed 's/^version = "\(.*\)"$/\1/')

@amrit110 amrit110 requested review from XkunW and jwilles April 16, 2025 18:52
@XkunW XkunW merged commit 7b26f83 into main Apr 21, 2025
7 checks passed
@XkunW XkunW deleted the add_multiversion_docs_support branch April 21, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants