Skip to content

📝 Fix type mismatch in abi.decode comparison #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vectorized merged 2 commits into from
Oct 6, 2025
Merged

📝 Fix type mismatch in abi.decode comparison #1494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcfb84a
📝 docs: fix type mismatch in abi.decode comparison (#1487)
mdqst Oct 6, 2025
836c879
Regen docs
Vectorized Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/utils/efficienthashlib.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,7 @@ function eq(bytes memory a, bytes32 b)
returns (bool result)
```

Returns `abi.decode(a, (bytes32)) == a`.
Returns `abi.decode(a, (bytes32)) == b`.

## Byte Slice Hashing Operations

Expand Down
2 changes: 1 addition & 1 deletion src/utils/EfficientHashLib.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,7 +754,7 @@ library EfficientHashLib {
}
}

/// @dev Returns `abi.decode(a, (bytes32)) == a`.
/// @dev Returns `abi.decode(a, (bytes32)) == b`.
function eq(bytes memory a, bytes32 b) internal pure returns (bool result) {
/// @solidity memory-safe-assembly
assembly {
Expand Down