Skip to content

👷‍♂️ Add solc 0.8.33 to CI #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atarpara merged 5 commits into from
Dec 29, 2025
Merged

👷‍♂️ Add solc 0.8.33 to CI #1505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c2762ef
Bump solc version
atarpara Dec 4, 2025
d00fd8e
Update solc version
atarpara Dec 26, 2025
d4c038d
Skip 0.8.32 version
atarpara Dec 26, 2025
2cb54e3
T
atarpara Dec 26, 2025
ccd202f
T
atarpara Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ci-all-via-ir.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,11 @@ jobs:
forge test --use 0.8.16 --via-ir &&
forge test --use 0.8.17 --via-ir
) ||
# NOTE: skipping solc 0.8.32 due to compiler bug
# https://github.com/argotorg/solidity/issues/16360
( [ "${{ matrix.profile }}" = "via-ir-3" ] &&
forge test --use 0.8.33 --via-ir &&
forge test --use 0.8.31 --via-ir &&
forge test --use 0.8.30 --via-ir &&
forge test --use 0.8.29 --via-ir &&
forge test --use 0.8.28 --via-ir &&
Expand Down
21 changes: 12 additions & 9 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
profile: [post-prague,post-prague-via-ir,solc-past-versions-0,solc-past-versions-1,via-ir,min-solc,min-solc-via-ir,intense]
profile: [post-osaka,post-osaka-via-ir,solc-past-versions-0,solc-past-versions-1,via-ir,min-solc,min-solc-via-ir,intense]
steps:
- uses: actions/checkout@v5
- name: Install Foundry Stable
Expand All @@ -25,15 +25,17 @@ jobs:
version: stable
- name: Install Dependencies
run: forge install
# NOTE: skipping solc 0.8.32 due to compiler bug
# https://github.com/argotorg/solidity/issues/16360
- name: Run Tests with ${{ matrix.profile }}
run: >
( [ "${{ matrix.profile }}" = "post-prague" ] &&
FOUNDRY_PROFILE=post_prague forge test --use 0.8.30 &&
FOUNDRY_PROFILE=zksync forge test --use 0.8.30
( [ "${{ matrix.profile }}" = "post-osaka" ] &&
FOUNDRY_PROFILE=post_osaka forge test --use 0.8.33 &&
FOUNDRY_PROFILE=zksync forge test --use 0.8.33
) ||
( [ "${{ matrix.profile }}" = "post-prague-via-ir" ] &&
FOUNDRY_PROFILE=post_prague forge test --use 0.8.30 --via-ir &&
FOUNDRY_PROFILE=zksync forge test --use 0.8.30 --via-ir
( [ "${{ matrix.profile }}" = "post-osaka-via-ir" ] &&
FOUNDRY_PROFILE=post_osaka forge test --use 0.8.33 --via-ir &&
FOUNDRY_PROFILE=zksync forge test --use 0.8.33 --via-ir
) ||
( [ "${{ matrix.profile }}" = "solc-past-versions-0" ] &&
FOUNDRY_PROFILE=pre_global_structs forge test --use 0.8.5 --fuzz-runs 16 &&
Expand Down Expand Up @@ -62,8 +64,9 @@ jobs:
forge test --use 0.8.26 --fuzz-runs 16 &&
forge test --use 0.8.27 --fuzz-runs 16 &&
forge test --use 0.8.28 --fuzz-runs 16 &&
forge test --use 0.8.29 --fuzz-runs 16

forge test --use 0.8.29 --fuzz-runs 16 &&
forge test --use 0.8.30 --fuzz-runs 16 &&
forge test --use 0.8.31 --fuzz-runs 16
) ||
( [ "${{ matrix.profile }}" = "via-ir" ] &&
forge test --via-ir
Expand Down
8 changes: 4 additions & 4 deletions foundry.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@

# The Default Profile
[profile.default]
solc_version = "0.8.30"
evm_version = "paris" # Cancun will be tested in the CI.
solc_version = "0.8.33"
evm_version = "paris" # osaka will be tested in the CI.
auto_detect_solc = false
optimizer = true
optimizer_runs = 1_000
Expand All @@ -20,8 +20,8 @@ remappings = [
skip = ["*/g/*", "*/*7702*", "*/*BlockHashLib*", "*/*Transient*", "*/ext/ithaca/*", "*/ext/zksync/*"]


[profile.post_prague]
evm_version = "prague"
[profile.post_osaka]
evm_version = "osaka"
skip = ["*/ext/ithaca/*"]

[profile.zksync]
Expand Down