Skip to content

DVOPS-310: Secrets detection pre-commit#134

Merged
ovceev merged 9 commits intomasterfrom
feature/DVOPS-310
Jul 10, 2025
Merged

DVOPS-310: Secrets detection pre-commit#134
ovceev merged 9 commits intomasterfrom
feature/DVOPS-310

Conversation

@ovceev
Copy link
Contributor

@ovceev ovceev commented Jul 8, 2025

what

  • newrelic upgrade
  • git secrets pre commit
  • node 22 upgrade
  • access logs

why

for security and observability

related issue

https://linear.app/paraswap/issue/DVOPS-310
https://linear.app/paraswap/issue/DVOPS-316

tests

pre-commit

git ci -m "test dummy creds"
🔍 Running git-secrets...
dummy.env:2:AWS_ACCESS_KEY_ID=AKIAABCDEFGHIJKLMNOP
testfile.pem:1:-----BEGIN RSA PRIVATE KEY-----

access log example

[2025-07-08T19:12:58.237] [ERROR] [ACCESS-LOG] ::ffff:10.10.11.165 10.10.11.112 HTTP/1.1 GET "/" 404 139 - 7ms

@ovceev ovceev requested a review from alexshchur July 8, 2025 15:21
@ovceev ovceev self-assigned this Jul 8, 2025
@linear
Copy link

linear bot commented Jul 8, 2025

DVOPS-310

Copy link
Contributor

@alexshchur alexshchur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked for me 👍

@ovceev ovceev merged commit cc9eac8 into master Jul 10, 2025
1 check passed
@ovceev ovceev deleted the feature/DVOPS-310 branch July 10, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants