Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code taken from https://github.com/DemonTPx/chrome-scroll-speed
Implements #357 (related commentary on 357: imwheel can't decrease the scroll speed)
IMPORTANT: Not ready for prod
I haven't figured out how to add a settings UI yet, the only way to change it is to edit
settings.jsonmanually to add thescrollSpeedkey. Additionally, in the fork I made scroll speed default to 0.24 — the default should probably be changed to 1.0 once the option is added to the settings UI.(Also I'm pretty sure that was not the right place to put the patch, so please point me to the right place)