Skip to content

use node.description for audio source names #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Creationsss wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −3
Open

use node.description for audio source names #1231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb56727
node.description
Creationsss Mar 21, 2026
f67994c
Merge branch 'main' into venmic-input-stream-desc
Creationsss Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/venmic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ ipcMain.handle(IpcEvents.VIRT_MIC_LIST, () => {
const { granularSelect } = Settings.store.audio ?? {};

const targets = obtainVenmic()
?.list(granularSelect ? ["node.name"] : undefined)
?.list(granularSelect ? ["node.name", "node.description"] : ["node.description"])
.filter(s => s["application.process.id"] !== audioPid);

return targets ? { ok: true, targets, hasPipewirePulse } : { ok: false, isGlibCxxOutdated };
Expand Down
5 changes: 3 additions & 2 deletions src/renderer/components/ScreenSharePicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,9 +477,10 @@ function mapToAudioItem(node: AudioSource, granularSelect?: boolean, deviceSelec
}

const name = node["application.name"];
const description = node["node.description"];

if (name) {
rtn.push({ name: name, value: { "application.name": name } });
rtn.push({ name: description || name, value: { "application.name": name } });
}

if (!granularSelect) {
Expand All @@ -489,7 +490,7 @@ function mapToAudioItem(node: AudioSource, granularSelect?: boolean, deviceSelec
const rawName = node["node.name"];

if (!name) {
rtn.push({ name: rawName, value: { "node.name": rawName } });
rtn.push({ name: description || rawName, value: { "node.name": rawName } });
}

const binary = node["application.process.binary"];
Expand Down
Loading