add condition to isDeckGameMode to fix nested desktop usage#1233
Open
sugoidogo wants to merge 1 commit intoVencord:mainfrom
Open
add condition to isDeckGameMode to fix nested desktop usage#1233sugoidogo wants to merge 1 commit intoVencord:mainfrom
sugoidogo wants to merge 1 commit intoVencord:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes vencord taking over the nested desktop session, as described in this discord message.
when running
npm test, the linter requested the statement be split into multiple lines, so I have done so.While testing, I noticed that the
XDG_CURRENT_DESKTOPvariable is actually also set by gamescope, so I changed the discussed check to pass onXDG_CURRENT_DESKTOP === "gamescope". Any desktop environment launched within gamescope should change this variable, so this check should fix the issue for any DE launched from game mode.I had considered that it may cover more scenarios if
XDG_CURRENT_DESKTOPwas used by itself to set the game mode variable, but since gamescope can be used without the steam client, not all features enabled by this variable make sense in those scenarios, so it seems best to include all 3 checks for the most correct behaviour.