Fix global threshold not being respected

readme.md

@@ -48,7 +48,7 @@ The following will use ImageHash to compare the images instead of the default Di
 ```cs
 [Test]
 public Task CompareImage() =>
-    VerifyFile("sample.jpg");
+    VerifyFile("sample1.jpg");
 ```
 <sup><a href='/src/Tests/Samples.cs#L4-L10' title='Snippet source file'>snippet source</a> | <a href='#snippet-CompareImage' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->

src/Directory.Build.props

@@ -2,7 +2,7 @@
 <Project>
   <PropertyGroup>
     <NoWarn>CS1591;CS0649;NU1608;NU1109</NoWarn>
-    <Version>3.0.2</Version>
+    <Version>3.0.3</Version>
     <AssemblyVersion>1.0.0</AssemblyVersion>
     <LangVersion>preview</LangVersion>
     <ImplicitUsings>enable</ImplicitUsings>
@@ -13,4 +13,4 @@
     <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
     <SuppressNETCoreSdkPreviewMessage>true</SuppressNETCoreSdkPreviewMessage>
   </PropertyGroup>
-</Project>
+</Project>

src/Tests.CustomThreshold/ModuleInitializer.cs

@@ -0,0 +1,9 @@
+static class ModuleInitializer
+{
+    [ModuleInitializer]
+    public static void Init()
+    {
+        VerifyImageSharpCompare.RegisterComparers(threshold: 10);
+        VerifierSettings.InitializePlugins();
+    }
+}

src/Tests.CustomThreshold/Tests.CustomThreshold.csproj

@@ -0,0 +1,17 @@
+
+<Project Sdk="Microsoft.NET.Sdk">
+  <PropertyGroup>
+    <TargetFramework>net8.0</TargetFramework>
+  </PropertyGroup>
+  <ItemGroup>
+    <PackageReference Include="NUnit" />
+    <PackageReference Include="NUnit3TestAdapter" />
+    <PackageReference Include="Verify.NUnit" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" />
+    <ProjectReference Include="..\Verify.ImageSharp.Compare\Verify.ImageSharp.Compare.csproj" />
+    <PackageReference Include="ProjectDefaults" PrivateAssets="all" />
+    <None Update=".\sample*.*">
+      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+    </None>
+  </ItemGroup>
+</Project>

src/Tests.CustomThreshold/Tests.FailingCompare.verified.txt

@@ -0,0 +1,23 @@
+{
+  Type: VerifyException,
+  Message:
+Directory: {ProjectDirectory}
+NotEqual:
+  - Received: Tests.FailingCompareInner.received.jpg
+    Verified: Tests.FailingCompareInner.verified.jpg
+
+FileContent:
+
+NotEqual:
+
+Received: Tests.FailingCompareInner.received.jpg
+Verified: Tests.FailingCompareInner.verified.jpg
+Compare Result:
+similarity(159345906) > threshold(10).
+If this difference is acceptable, use:
+
+ * Globally: VerifyImageSharpCompare.RegisterComparers(159345906);
+ * For one test: Verifier.VerifyFile("file.jpg").UseImageHash(159345906);
+
+
+}

src/Tests.CustomThreshold/Tests.cs

@@ -0,0 +1,18 @@
+[TestFixture]
+public class Tests
+{
+    [Test]
+    public Task Working() =>
+        VerifyFile("sample1.jpg");
+
+    [Test]
+    public Task FailingCompare() =>
+        ThrowsTask(async () =>
+            {
+                await VerifyFile("sample2.jpg")
+                    .DisableDiff()
+                    .UseMethodName("FailingCompareInner");
+            })
+            .IgnoreStackTrace()
+            .ScrubLinesContaining("clipboard", "DiffEngineTray");
+}

src/Tests/Samples.cs

@@ -5,7 +5,7 @@ public class Samples
 
     [Test]
     public Task CompareImage() =>
-        VerifyFile("sample.jpg");
+        VerifyFile("sample1.jpg");
 
     #endregion
-}
+}

src/Tests/Tests.FailingCompare.verified.txt

@@ -13,7 +13,11 @@ NotEqual:
 Received: Tests.FailingCompareInner.received.jpg
 Verified: Tests.FailingCompareInner.verified.jpg
 Compare Result:
-Size of images differ.
+similarity(159345906) > threshold(85).
+If this difference is acceptable, use:
+
+ * Globally: VerifyImageSharpCompare.RegisterComparers(159345906);
+ * For one test: Verifier.VerifyFile("file.jpg").UseImageHash(159345906);
 
 
 }

src/Tests/Tests.cs

@@ -1,15 +1,19 @@
 [TestFixture]
 public class Tests
 {
+    [Test]
+    public Task Working() =>
+        VerifyFile("sample1.jpg");
+
     [Test]
     public Task FailingCompare() =>
         ThrowsTask(async () =>
             {
-                await VerifyFile("sample.jpg")
+                await VerifyFile("sample2.jpg")
                     .DisableDiff()
                     .UseMethodName("FailingCompareInner")
                     .UseImageHash(85);
             })
             .IgnoreStackTrace()
             .ScrubLinesContaining("clipboard", "DiffEngineTray");
-}
+}

src/Tests/Tests.csproj

@@ -1,7 +1,7 @@
 
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net10.0</TargetFramework>
   </PropertyGroup>
   <ItemGroup>
     <PackageReference Include="MarkdownSnippets.MsBuild" PrivateAssets="all" />
@@ -12,7 +12,7 @@
     <PackageReference Include="Microsoft.NET.Test.Sdk" />
     <ProjectReference Include="..\Verify.ImageSharp.Compare\Verify.ImageSharp.Compare.csproj" />
     <PackageReference Include="ProjectDefaults" PrivateAssets="all" />
-    <None Update="sample.*">
+    <None Update=".\sample*.*">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </None>
   </ItemGroup>

src/Verify.ImageSharp.Compare.slnx

@@ -13,6 +13,7 @@
     <File Path="mdsnippets.json" />
     <File Path="nuget.md" />
   </Folder>
+  <Project Path="Tests.CustomThreshold/Tests.CustomThreshold.csproj" />
   <Project Path="Tests/Tests.csproj" />
   <Project Path="Verify.ImageSharp.Compare/Verify.ImageSharp.Compare.csproj" />
 </Solution>

src/Verify.ImageSharp.Compare/VerifyImageSharpCompare.cs

@@ -2,6 +2,8 @@
 
 public static class VerifyImageSharpCompare
 {
+    static HashSet<string> registeredComparers = [];
+
     public static bool Initialized { get; private set; }
 
     /// <summary>
@@ -23,6 +25,7 @@ public static void Initialize()
     public static void RegisterComparers(int threshold = 5)
     {
         InnerVerifier.ThrowIfVerifyHasBeenRun();
+
         RegisterComparer(threshold, "png");
         RegisterComparer(threshold, "bmp");
         RegisterComparer(threshold, "jpg");
@@ -36,10 +39,17 @@ public static SettingsTask UseImageHash(this SettingsTask settings, int threshol
         settings.UseStreamComparer(
             (received, verified, _) => Compare(threshold, received, verified));
 
-    public static void RegisterComparer(int threshold, string extension) =>
+    public static void RegisterComparer(int threshold, string extension)
+    {
+        if (!registeredComparers.Add(extension))
+        {
+            return;
+        }
+
         VerifierSettings.RegisterStreamComparer(
             extension,
             (received, verified, _) => Compare(threshold, received, verified));
+    }
 
     static Task<CompareResult> Compare(int threshold, Stream received, Stream verified)
     {
@@ -72,4 +82,4 @@ static Task<CompareResult> Compare(int threshold, Stream received, Stream verifi
               * For one test: Verifier.VerifyFile("file.jpg").UseImageHash({absoluteError});
              """));
     }
-}
+}