Skip to content

Conversation

moshe5745
Copy link

@moshe5745 moshe5745 commented Mar 5, 2025

Status

READY

Description

This pull request enhances Zsh completion support by adding interactive menu selection and colored completion lists. Specifically, it introduces two zstyle configurations:

  • zstyle ':completion:*' menu yes select: Enables a menu-style completion interface in Zsh, allowing users to navigate options with arrow keys.
  • zstyle ':completion:*' list-colors '': Adds color highlighting to completion suggestions for better visibility.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@moshe5745 moshe5745 requested a review from a team as a code owner March 5, 2025 11:35
@marcossevilla
Copy link
Member

/windsurf-review

marcossevilla
marcossevilla previously approved these changes Jul 8, 2025
omartinma
omartinma previously approved these changes Jul 9, 2025
Copy link

@omartinma omartinma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution @moshe5745 ⭐️

@marcossevilla
Copy link
Member

hey @moshe5745, finally workflows are running, but seems to need an update on the tests too... let me know if you can take this, otherwise I can take a look, thanks again for your contribution!

@moshe5745
Copy link
Author

@marcossevilla Hey
I will try to handle this

@moshe5745 moshe5745 dismissed stale reviews from omartinma and marcossevilla via 8cf2190 August 31, 2025 08:52
@moshe5745
Copy link
Author

@marcossevilla Done

@marcossevilla
Copy link
Member

hey @moshe5745, thanks! seems like a test still failing due to formatting

@moshe5745
Copy link
Author

@marcossevilla Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants