Skip to content

refactor: stop using deprecated serviceWorkerVersion #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 26, 2024
Merged

refactor: stop using deprecated serviceWorkerVersion #29

merged 4 commits into from
Aug 26, 2024

Conversation

alestiago
Copy link
Contributor

@alestiago alestiago commented Aug 22, 2024 •
edited
Loading

Status

READY

Description

Resolves #26

Video

CleanShot.2024-08-22.at.12.09.42.mp4

Try it out

  1. Clone the repository and checkout to this branch.

  2. Get hook dependencies (from ./hooks/):

dart pub get
  1. Create a flutter web sample project (from .):
flutter create sample --platforms web
  1. Activate Mason:
dart pub global activate mason_cli
  1. Initialize Mason (from sample):
mason init
  1. Add local flutter_web_preloader (from sample):
mason add flutter_web_preloader --path ..
  1. Make flutter_web_preloader (from sample):
mason make flutter_web_preloader
  1. Run the application in chrome (from sample):
flutter run -d chrome

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alestiago alestiago requested a review from a team as a code owner August 22, 2024 10:41
@alestiago alestiago self-assigned this Aug 22, 2024
@alestiago alestiago added the refactor A code change that neither fixes a bug nor add a feature label Aug 22, 2024
tomarra
tomarra previously approved these changes Aug 22, 2024
View reviewed changes
erickzanardo
erickzanardo approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@erickzanardo erickzanardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, but LGTM!

@alestiago alestiago merged commit c66a448 into main Aug 26, 2024
2 checks passed
@alestiago alestiago deleted the alestiago/service-worker-deprecation branch August 26, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzanardo erickzanardo Awaiting requested review from erickzanardo

1 more reviewer

@tomarra tomarra tomarra approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@alestiago alestiago

Labels
refactor A code change that neither fixes a bug nor add a feature
Projects
VGV Open Source 🦄 🧙🌟
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: stop using deprecated serviceWorkerVersion
3 participants
@alestiago @tomarra @erickzanardo