Skip to content

fix: update package path normalization in licenses command #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ryzizub wants to merge 1 commit into from
Closed

fix: update package path normalization in licenses command #1270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/commands/packages/commands/check/commands/licenses.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ class PackagesCheckLicensesCommand extends Command<int> {
continue;
}

final packagePath = path.normalize(cachePackageEntry.root.path);
final packagePath = path.normalize(path.fromUri(cachePackageEntry.root));
Copy link
Contributor

@wolfenrain wolfenrain Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try to run our e2e test on windows because it would most likely have been caught then: https://github.com/VeryGoodOpenSource/very_good_cli/blob/main/.github/workflows/e2e.yaml#L51

final packageDirectory = Directory(packagePath);
if (!packageDirectory.existsSync()) {
final errorMessage =
Expand Down