Skip to content

feat: bump template bundles #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions wants to merge 3 commits into from
Closed

feat: bump template bundles #1312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fb7fbb
feat: bump template bundles
vgvbot Jul 28, 2025
b0dc425
fix: tests
matiasleyba Jul 28, 2025
893724b
fix: create command tests
matiasleyba Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e/test/commands/create/dart_cli/dart_cli_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ void main() {
]);
expect(result, equals(ExitCode.success.code));

final workingDirectory = path.join(tempDirectory.path, 'my_cli');
final workingDirectory = path.join(tempDirectory.path);

// add coverage to collect coverage on dart test
await expectSuccessfulProcessResult('dart', [
Expand Down
2 changes: 1 addition & 1 deletion e2e/test/commands/create/dart_package/dart_pkg_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ void main() {
]);
expect(result, equals(ExitCode.success.code));

final workingDirectory = path.join(tempDirectory.path, 'very_good_dart');
final workingDirectory = path.join(tempDirectory.path);

// add coverage to collect coverage on dart test
await expectSuccessfulProcessResult('dart', [
Expand Down
5 changes: 1 addition & 4 deletions e2e/test/commands/create/docs_site/docs_site_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,7 @@ void main() {
]);
expect(result, equals(ExitCode.success.code));

final workingDirectory = path.join(
tempDirectory.path,
'very_good_docs_site',
);
final workingDirectory = path.join(tempDirectory.path);

await expectSuccessfulProcessResult(
'npm',
Expand Down
5 changes: 1 addition & 4 deletions e2e/test/commands/create/flame_game/flame_game_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,7 @@ void main() {
]);
expect(result, equals(ExitCode.success.code));

final workingDirectory = path.join(
tempDirectory.path,
'very_good_flame_game',
);
final workingDirectory = path.join(tempDirectory.path);

await expectSuccessfulProcessResult('dart', [
'format',
Expand Down
2 changes: 1 addition & 1 deletion e2e/test/commands/create/flutter_app/core_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ void main() {
]);
expect(result, equals(ExitCode.success.code));

final workingDirectory = path.join(tempDirectory.path, 'very_good_core');
final workingDirectory = path.join(tempDirectory.path);

await expectSuccessfulProcessResult('dart', [
'format',
Expand Down
5 changes: 1 addition & 4 deletions e2e/test/commands/create/flutter_package/flutter_pkg_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,7 @@ void main() {
]);
expect(result, equals(ExitCode.success.code));

final workingDirectory = path.join(
tempDirectory.path,
'very_good_flutter',
);
final workingDirectory = path.join(tempDirectory.path);

await expectSuccessfulProcessResult('dart', [
'format',
Expand Down
2 changes: 1 addition & 1 deletion e2e/test/commands/create/flutter_plugin/flutter_plugin_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ void main() {
addTearDown(() => tempDirectory.deleteSync(recursive: true));

const pluginName = 'my_plugin';
final pluginDirectory = path.join(tempDirectory.path, pluginName);
final pluginDirectory = path.join(tempDirectory.path);

final result = await commandRunner.run([
'create',
Expand Down
6 changes: 1 addition & 5 deletions lib/src/commands/create/commands/create_subcommand.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import 'package:args/args.dart';
import 'package:args/command_runner.dart';
import 'package:mason/mason.dart';
import 'package:meta/meta.dart';
import 'package:path/path.dart' as path;
import 'package:very_good_cli/src/commands/commands.dart';
import 'package:very_good_cli/src/commands/create/templates/templates.dart';

Expand Down Expand Up @@ -209,10 +208,7 @@ abstract class CreateSubCommand extends Command<int> {
final files = await generator.generate(target, vars: vars, logger: logger);
generateProgress.complete('Generated ${files.length} file(s)');

await template.onGenerateComplete(
logger,
Directory(path.join(target.dir.path, projectName)),
);
await template.onGenerateComplete(logger, outputDirectory);

return ExitCode.success.code;
}
Expand Down
829 changes: 304 additions & 525 deletions lib/src/commands/create/templates/very_good_core/very_good_core_bundle.dart
View file
Open in desktop

Large diffs are not rendered by default.

71 changes: 28 additions & 43 deletions lib/src/commands/create/templates/very_good_dart_cli/very_good_dart_cli_bundle.dart
View file
Open in desktop

Large diffs are not rendered by default.

67 changes: 27 additions & 40 deletions lib/src/commands/create/templates/very_good_dart_package/very_good_dart_package_bundle.dart
View file
Open in desktop

Large diffs are not rendered by default.

88 changes: 40 additions & 48 deletions lib/src/commands/create/templates/very_good_docs_site/very_good_docs_site_bundle.dart
View file
Open in desktop

Large diffs are not rendered by default.

925 changes: 352 additions & 573 deletions lib/src/commands/create/templates/very_good_flame_game/very_good_flame_game_bundle.dart
View file
Open in desktop

Large diffs are not rendered by default.

67 changes: 27 additions & 40 deletions ...commands/create/templates/very_good_flutter_package/very_good_flutter_package_bundle.dart
View file
Open in desktop

Large diffs are not rendered by default.

491 changes: 234 additions & 257 deletions ...c/commands/create/templates/very_good_flutter_plugin/very_good_flutter_plugin_bundle.dart
View file
Open in desktop

Large diffs are not rendered by default.

261 changes: 104 additions & 157 deletions lib/src/commands/create/templates/very_good_wear_app/very_good_wear_app_bundle.dart
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion test/src/commands/create/commands/dart_cli_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ void main() {
).thenAnswer((invocation) async {
final target =
invocation.positionalArguments.first as DirectoryGeneratorTarget;
File(path.join(target.dir.path, 'my_cli', 'pubspec.yaml'))
File(path.join(target.dir.path, 'pubspec.yaml'))
..createSync(recursive: true)
..writeAsStringSync(pubspec);
return generatedFiles;
Expand Down
2 changes: 1 addition & 1 deletion test/src/commands/create/commands/dart_package_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ void main() {
).thenAnswer((invocation) async {
final target =
invocation.positionalArguments.first as DirectoryGeneratorTarget;
File(path.join(target.dir.path, 'my_package', 'pubspec.yaml'))
File(path.join(target.dir.path, 'pubspec.yaml'))
..createSync(recursive: true)
..writeAsStringSync(pubspec);
return generatedFiles;
Expand Down
2 changes: 1 addition & 1 deletion test/src/commands/create/commands/docs_site_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ void main() {
).thenAnswer((invocation) async {
final target =
invocation.positionalArguments.first as DirectoryGeneratorTarget;
File(path.join(target.dir.path, 'my_docs_site', 'pubspec.yaml'))
File(path.join(target.dir.path, 'pubspec.yaml'))
..createSync(recursive: true)
..writeAsStringSync(pubspec);
return generatedFiles;
Expand Down
2 changes: 1 addition & 1 deletion test/src/commands/create/commands/flame_game_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ void main() {
).thenAnswer((invocation) async {
final target =
invocation.positionalArguments.first as DirectoryGeneratorTarget;
File(path.join(target.dir.path, 'my_app', 'pubspec.yaml'))
File(path.join(target.dir.path, 'pubspec.yaml'))
..createSync(recursive: true)
..writeAsStringSync(pubspec);
return generatedFiles;
Expand Down
2 changes: 1 addition & 1 deletion test/src/commands/create/commands/flutter_app_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ void main() {
).thenAnswer((invocation) async {
final target =
invocation.positionalArguments.first as DirectoryGeneratorTarget;
File(path.join(target.dir.path, 'my_app', 'pubspec.yaml'))
File(path.join(target.dir.path, 'pubspec.yaml'))
..createSync(recursive: true)
..writeAsStringSync(pubspec);
return generatedFiles;
Expand Down
2 changes: 1 addition & 1 deletion test/src/commands/create/commands/flutter_package_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ void main() {
).thenAnswer((invocation) async {
final target =
invocation.positionalArguments.first as DirectoryGeneratorTarget;
File(path.join(target.dir.path, 'my_flutter_package', 'pubspec.yaml'))
File(path.join(target.dir.path, 'pubspec.yaml'))
..createSync(recursive: true)
..writeAsStringSync(pubspec);
return generatedFiles;
Expand Down
2 changes: 1 addition & 1 deletion test/src/commands/create/commands/flutter_plugin_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ void main() {
).thenAnswer((invocation) async {
final target =
invocation.positionalArguments.first as DirectoryGeneratorTarget;
File(path.join(target.dir.path, 'my_plugin', 'pubspec.yaml'))
File(path.join(target.dir.path, 'pubspec.yaml'))
..createSync(recursive: true)
..writeAsStringSync(pubspec);
return generatedFiles;
Expand Down
Loading