-
Notifications
You must be signed in to change notification settings - Fork 228
feat: allow very_good create .
#996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow very_good create .
#996
Conversation
|
fixes #969 |
|
this is ready for review. by the way, the repo had 37 broken tests when I cloned it on my machine. I was wondering if I should submit those as issues. |
|
Fixed the formatting issue by updating from |
89ded61 to
b706a2d
Compare
|
Pinging @wolfenrain |
wolfenrain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, sorry for the late follow-up on my part. I will try and test out this branch later today to make sure it is backwards compatible but from the looks of it we should be good!
|
sure thing, let me know if there's anything I need to do. |
The CI seems to be failing on some tests, mind having a look at that? I suspect that the tests are failing because of wrong parameters (might mean it isnt backwards compatible like we hoped?) |
|
I can't tell which tests are failing. See this issue for more details #1162 |
Take a look at the details of the Actions output here. You can see the failing tests in the output. |
|
hey @a-wallen, can you take a look at the CI failures so we can merge this? thanks! |
|
hey @a-wallen! do you need any help with this? I'd be happy to help you move past the finish line 👍 |
bb39ca7 to
e0fcb48
Compare
|
We are updating the |


Status
READY/IN DEVELOPMENT/HOLD
READY
Description
Allows
.as a project name (likeflutter create .)Type of Change