Skip to content

Conversation

@a-wallen
Copy link
Contributor

@a-wallen a-wallen commented Mar 19, 2024

Status

READY/IN DEVELOPMENT/HOLD
READY

Description

Allows . as a project name (like flutter create .)

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@a-wallen a-wallen requested a review from a team as a code owner March 19, 2024 07:42
@a-wallen
Copy link
Contributor Author

fixes #969

@a-wallen
Copy link
Contributor Author

this is ready for review.

by the way, the repo had 37 broken tests when I cloned it on my machine. I was wondering if I should submit those as issues.

@tomarra
Copy link
Contributor

tomarra commented Mar 27, 2024

Fixed the formatting issue by updating from main via #1003 so CI is now passing. @wolfenrain can we get a review here?

@a-wallen a-wallen force-pushed the allow_create_in_cwd branch from 89ded61 to b706a2d Compare July 9, 2024 23:37
@alestiago alestiago requested a review from wolfenrain July 10, 2024 09:43
@alestiago
Copy link
Contributor

Pinging @wolfenrain

@tomarra tomarra added the p2 Important issues not at the top of the work list label Aug 30, 2024
Copy link
Contributor

@wolfenrain wolfenrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the late follow-up on my part. I will try and test out this branch later today to make sure it is backwards compatible but from the looks of it we should be good!

@a-wallen
Copy link
Contributor Author

sure thing, let me know if there's anything I need to do.

@wolfenrain
Copy link
Contributor

sure thing, let me know if there's anything I need to do.

The CI seems to be failing on some tests, mind having a look at that? I suspect that the tests are failing because of wrong parameters (might mean it isnt backwards compatible like we hoped?)

@a-wallen
Copy link
Contributor Author

a-wallen commented Oct 9, 2024

I can't tell which tests are failing. See this issue for more details #1162

@tomarra
Copy link
Contributor

tomarra commented Oct 10, 2024

I can't tell which tests are failing. See this issue for more details #1162

Take a look at the details of the Actions output here. You can see the failing tests in the output.

@alestiago alestiago moved this from Community to Needs Triage in VGV Open Source 🦄 🧙🌟 Mar 4, 2025
@marcossevilla
Copy link
Member

hey @a-wallen, can you take a look at the CI failures so we can merge this? thanks!

@marcossevilla marcossevilla assigned a-wallen and unassigned wolfenrain Jul 3, 2025
@marcossevilla marcossevilla added the waiting for response Waiting for follow up label Jul 3, 2025
@marcossevilla
Copy link
Member

hey @a-wallen! do you need any help with this? I'd be happy to help you move past the finish line 👍

@matiasleyba matiasleyba force-pushed the allow_create_in_cwd branch from bb39ca7 to e0fcb48 Compare July 17, 2025 16:17
@matiasleyba
Copy link
Contributor

We are updating the very_good_templates to support this feature.
I'll move this PR to draft until we have all the templates updated and then I will finish the implementation of this feature.

@matiasleyba matiasleyba self-assigned this Jul 25, 2025
@matiasleyba
Copy link
Contributor

After discussing the feature, we've updated the CLI to allow . as a valid project name to create a project in the current directory, without wrapping it in a new folder. However, the project_name parameter will no be treated as a path.

✅ Accepted commands:

  • very_good create dart_package my_package
    → Creates the project in ./my_package (same behavior as before).
Screen.Recording.2025-07-28.at.11.20.54.AM.mov
  • very_good create dart_package .
    → Creates the project in the current directory (New).
Screen.Recording.2025-07-28.at.11.23.31.AM.mov
  • very_good create dart_package my_package --output-directory path/to
    → Creates the project in path/to/my_package.
Screen.Recording.2025-07-28.at.11.24.51.AM.mov

❌ Invalid commands (will result in an error):

  • very_good create dart_package . --output-directory path/to
    (Using . with --output-directory is not supported)
image
  • very_good create dart_package path/my_package --output-directory path/to
    (project_name must not include a path)
image

ℹ️ Note: A following PR will include updates on the site documentation.

@matiasleyba matiasleyba marked this pull request as ready for review July 28, 2025 17:49
@matiasleyba matiasleyba requested a review from a team July 28, 2025 17:50
@omartinma omartinma merged commit 287f751 into VeryGoodOpenSource:main Aug 4, 2025
30 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in VGV Open Source 🦄 🧙🌟 Aug 4, 2025
@vgvbot vgvbot mentioned this pull request Aug 4, 2025
@omartinma omartinma removed the waiting for response Waiting for follow up label Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 Important issues not at the top of the work list

Projects

Development

Successfully merging this pull request may close these issues.

7 participants