feat: expose shrinkWrap of CustomScrollView #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add shrinkWrap property to InfiniteList widget - Update documentation to reference CustomScrollView.shrinkWrap - Add tests to ensure property gets proxied and defaults to false - Update README with shrinkWrap documentation Addresses feedback from PR VeryGoodOpenSource#71
7 tasks
Member
|
@ablause hi! thanks for the contribution! are you planning to update the PR soon? we want to get this merged :) |
Contributor
Author
|
No further changes needed you can go ahead and merge 👍 |
marcossevilla
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
This PR exposes the shrinkWrap parameter of the CustomScrollView used internally in VeryGoodInfiniteList, allowing better control over the list’s layout behavior.
This work is based on the initial contribution from #71 by @limcheekin, which appears inactive.
Type of Change