fix: license_check failed on flutter pkgs #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r to specify a flutter_version or a dart_sdk version to indicate which dependencies to get.
marcossevilla
changed the title
.github/workflows/license_check.yml
Outdated
| uses: actions/checkout@v5 | ||
|
|
||
| - name: Check for conflicting SDK inputs | ||
| if: ${{ inputs.flutter_version != '' && inputs.dart_sdk != '' }} |
There was a problem hiding this comment.
can we create a temp env variable instead so we don't repeat this code in every conditional?
There was a problem hiding this comment.
@marcossevilla I'm new to writing yaml files. Please show me the change with a temp env you are suggesting. Thanks.
There was a problem hiding this comment.
sure! you can check this part of the GitHub docs where you can add it as env variable with the same expression you already have
matiasleyba
reviewed
Aug 21, 2025
…value is specified or not. But that requires us to use a step output variable to default to "stable" when no dart_sdk is specified.
| - name: 🎯 Setup Dart | ||
| - name: Show warning if conflicting SDK inputs | ||
| if: ${{ env.SHOW_DART_FLUTTER_WARNING == 'true' }} | ||
| run: echo "::warning::Both 'flutter_version' and 'dart_sdk' were specified. The workflow will proceed with the Flutter SDK setup." |
There was a problem hiding this comment.
I think we should also validate when none were specified right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Closes #297
Now allow caller to specify a flutter_version or a dart_sdk version to indicate which dependencies to get. If you don't specify either it will function as before using the "stable" dart_sdk. If both flutter_version and dart_sdk are specified, it will use flutter dependencies but also display a warning message.
Type of Change