Refactor navigation menu to simplify structure and update status disp… #708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lay for priority programs
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the navigation menu by simplifying the menu data structure and updating the megamenu component for clearer status display.
- Simplifies the menu data structure by removing unused interfaces and updating the NavigationItem type.
- Reorganizes navigation items with unique IDs and adds a new "Donate" top-level menu item.
- Updates the megamenu component to replace the Badge component with an accessible span element containing an emoji for items with a "hot" status.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/data/menu.ts | Removes unused types, updates NavigationItem type, and reorganizes menu items. |
| src/components/menu/main-menu/megamenu.tsx | Replaces the Badge component with an accessible span element for "hot" status. |
Comments suppressed due to low confidence (1)
src/components/menu/main-menu/megamenu.tsx:49
- [nitpick] Consider updating the aria-label and title attributes to reflect 'hot' status (e.g., 'Hot') rather than 'Priority Program' for improved clarity and consistency with the menu status.
aria-label="Priority Program"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the megamenu component and simplifies the menu data structure. Key changes include replacing the
Badgecomponent with an emoji for "hot" status, removing unused types related to megamenu groups and banners, and restructuring the navigation menu data for clarity and maintainability.Refactoring the megamenu component:
Badgecomponent with a span element containing an emoji (🎖️) for items with a "hot" status. The new implementation includes accessibility attributes (role,aria-label, andtitle). (src/components/menu/main-menu/megamenu.tsx, src/components/menu/main-menu/megamenu.tsxL45-R53)Simplifying the menu data structure:
MegaMenuGroup,BannerSection, andMegaMenuItem) and updated theNavigationItemtype to include onlySubMenuItemandMenuItem. (src/data/menu.ts, src/data/menu.tsL16-R95)navigationarray to assign unique IDs, reorganize menu items, and add a new "Donate" top-level menu item. (src/data/menu.ts, src/data/menu.tsL16-R95)…lay for priority programs