Skip to content

Conversation

@EthanKeating
Copy link
Contributor

This PR addresses an issue where 1.7 hologram entities do not interpolate movement, resulting in choppy or jittery visuals when holograms move.

The issue is resolved by wrapping the hologram in an interpolated entity, in this case a Squid, which is not affected by gravity and its movement is interpolated by the client. This provides a smooth animation during movement.

Before:
https://github.com/user-attachments/assets/68e10115-66ab-4671-b673-3f8bce9b0ba2

After
https://github.com/user-attachments/assets/0ad093fe-d240-4b33-9b63-b3e0f9e8f18c

This will add a little bit of network & client overhead as it will be spawning an extra entity per hologram. But, this fix has been tested in production for a little over 2 months and has not caused me any issues personally. A config option could be a good option if you are concerned about the network and client overhead.

Copy link
Member

@FlorianMichael FlorianMichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good, please keep the original formatting next time as currently it's hard to review with the git diff being broken

@EthanKeating
Copy link
Contributor Author

I have made your requested changes, thanks for the tips. I did not change the offset as I found the previous offset positioned the holograms higher than what 1.8+ users were seeing.

@FlorianMichael
Copy link
Member

Thanks. This should be fine, I am going to pull later after doing some final testing.

@FlorianMichael FlorianMichael merged commit 8d8675a into ViaVersion:master May 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants