Hologram movement fix for 1.7 clients #580
Merged
+456
−445
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where 1.7 hologram entities do not interpolate movement, resulting in choppy or jittery visuals when holograms move.
The issue is resolved by wrapping the hologram in an interpolated entity, in this case a Squid, which is not affected by gravity and its movement is interpolated by the client. This provides a smooth animation during movement.
Before:
https://github.com/user-attachments/assets/68e10115-66ab-4671-b673-3f8bce9b0ba2
After
https://github.com/user-attachments/assets/0ad093fe-d240-4b33-9b63-b3e0f9e8f18c
This will add a little bit of network & client overhead as it will be spawning an extra entity per hologram. But, this fix has been tested in production for a little over 2 months and has not caused me any issues personally. A config option could be a good option if you are concerned about the network and client overhead.