app/vlagent/kubernetescollector: add support for dynamic token and certificates reloading #999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/victorialogs/CHANGELOG.md
Outdated
|
|
||
| ## tip | ||
|
|
||
| * FEATURE: [Kubernetes Collector](https://docs.victoriametrics.com/victorialogs/vlagent/#collect-kubernetes-pod-logs): add support for dynamic token and certificates reloading. Previously, vlagent only read credentials at startup, which led to authentication errors after token rotation. See [#995](https://github.com/VictoriaMetrics/VictoriaLogs/issues/995). |
Member
Author
There was a problem hiding this comment.
Changed to BUGFIX. But to me, it is a feature, since we didn't expect vlagent to be able to rotate Kubernetes tokens.
vadimalekseev
force-pushed
the
reload-k8s-creds
branch
2 times, most recently
from
80ade1c to
bb69c93
Compare
…rtificates reloading
vadimalekseev
force-pushed
the
reload-k8s-creds
branch
from
bb69c93 to
6f258c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Add support for dynamic token and certificates reloading.
Fixes #995.
Checklist
The following checks are mandatory: