Skip to content

file: load should propage file not found error#84

Merged
makasim merged 1 commit intomasterfrom
load-cache-propage-file-not-found-error
May 21, 2025
Merged

file: load should propage file not found error#84
makasim merged 1 commit intomasterfrom
load-cache-propage-file-not-found-error

Conversation

@makasim
Copy link
Member

@makasim makasim commented May 21, 2025

So it could be handled by the caller. For example, here VictoriaMetrics/VictoriaMetrics#8952

@makasim makasim requested review from hagen1778, rtm0 and zekker6 May 21, 2025 11:54
tenmozes
tenmozes previously approved these changes May 21, 2025
hagen1778
hagen1778 previously approved these changes May 21, 2025
@makasim makasim dismissed stale reviews from hagen1778 and tenmozes via 4eccce6 May 21, 2025 12:03
@makasim makasim force-pushed the load-cache-propage-file-not-found-error branch 2 times, most recently from 4eccce6 to 60a37a4 Compare May 21, 2025 12:06
@makasim makasim force-pushed the load-cache-propage-file-not-found-error branch from 60a37a4 to 65c4735 Compare May 21, 2025 12:27
@codecov
Copy link

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.96%. Comparing base (f180005) to head (65c4735).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
file.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   76.23%   76.96%   +0.73%     
==========================================
  Files           4        4              
  Lines         547      547              
==========================================
+ Hits          417      421       +4     
+ Misses         73       71       -2     
+ Partials       57       55       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@makasim makasim merged commit e439f07 into master May 21, 2025
5 of 6 checks passed
@makasim makasim deleted the load-cache-propage-file-not-found-error branch May 21, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants