file: load from file should allow configure maxBytes#86
Conversation
It is needed to implement same behavior as load from file or new does (specifically this check https://github.com/VictoriaMetrics/fastcache/blob/e439f07b570777a09fb9b662e47bd52d895c349b/file.go#L133-L139) Related to https://github.com/VictoriaMetrics/VictoriaMetrics/pull/8952/files
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #86 +/- ##
=======================================
Coverage 76.96% 76.96%
=======================================
Files 4 4
Lines 547 547
=======================================
Hits 421 421
Misses 71 71
Partials 55 55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request breaks users' code, since it changes the signature of the public function - Note that this rule must be applied to all our public packages, which have |
|
@valyala Apologies for this, it's entirely my fault. I'll get it fixed right away. |
|
reverted in #88 |
It is needed to implement same behavior as
LoadFromFileOrNewdoes. It respects given maxBytes and pass it toloadso this checkfastcache/file.go
Lines 133 to 139 in e439f07
Related to https://github.com/VictoriaMetrics/VictoriaMetrics/pull/8952/files